review suggestions + spelling

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
This commit is contained in:
Rachel Powers
2024-06-28 09:59:57 -07:00
parent 492c78a570
commit 8488d11c69
4 changed files with 30 additions and 27 deletions

View File

@@ -38,7 +38,6 @@
#include <meta/VersionList.h>
#include <QSaveFile>
#include <optional>
#include "Application.h"
#include "FileSystem.h"
@@ -50,6 +49,14 @@
#include <assert.h>
const QMap<QString, ModloaderMapEntry> Component::KNOWN_MODLOADERS = {
{ "net.neoforged", { ModPlatform::NeoForge, { "net.minecraftforge", "net.fabricmc.fabric-loader", "net.fabricmc.fabric-loader" } } },
{ "net.minecraftforge", { ModPlatform::Forge, { "net.neoforged", "net.fabricmc.fabric-loader", "net.fabricmc.fabric-loader" } } },
{ "net.fabricmc.fabric-loader", { ModPlatform::Fabric, { "net.minecraftforge", "net.neoforged", "org.quiltmc.quilt-loader" } } },
{ "org.quiltmc.quilt-loader", { ModPlatform::Quilt, { "net.minecraftforge", "net.neoforged", "net.fabricmc.fabric-loader" } } },
{ "com.mumfrey.liteloader", { ModPlatform::LiteLoader, {} } }
};
Component::Component(PackProfile* parent, const QString& uid)
{
assert(parent);
@@ -231,11 +238,11 @@ bool Component::isKnownModloader()
return iter != KNOWN_MODLOADERS.cend();
}
QStringList Component::knownConfictingComponents()
QStringList Component::knownConflictingComponents()
{
auto iter = KNOWN_MODLOADERS.find(m_uid);
if (iter != KNOWN_MODLOADERS.cend()) {
return (*iter).knownConfictingComponents;
return (*iter).knownConflictingComponents;
} else {
return {};
}
@@ -276,12 +283,16 @@ void Component::addComponentProblem(ProblemSeverity severity, const QString& des
m_componentProblemSeverity = severity;
}
m_componentProblems.append({ severity, description });
emit dataChanged();
}
void Component::resetComponentProblems()
{
m_componentProblems.clear();
m_componentProblemSeverity = ProblemSeverity::None;
emit dataChanged();
}
void Component::setVersion(const QString& version)