Check return value of 'virtual bool QFile::open(QIODeviceBase::OpenMode)'

Signed-off-by: Dylan Schooner <dschooner05@gmail.com>
2025-10-30 03:15:14 -04:00
parent 2982e6e7c9
commit 8d42bdaf6b
9 changed files with 63 additions and 28 deletions
--- a/launcher/ui/dialogs/AboutDialog.cpp
+++ b/launcher/ui/dialogs/AboutDialog.cpp
@@ -124,9 +124,14 @@ QString getCreditsHtml()
 QString getLicenseHtml()
 {
    QFile dataFile(":/documents/COPYING.md");
-    dataFile.open(QIODevice::ReadOnly);
-    QString output = markdownToHTML(dataFile.readAll());
-    return output;
+    if (dataFile.open(QIODevice::ReadOnly)) {
+        QString output = markdownToHTML(dataFile.readAll());
+        dataFile.close();
+        return output;
+    } else {
+        qWarning() << "Failed to open file '" << dataFile.fileName() << "' for reading!";
+        return QString();
+    }
 }

 }  // namespace