Remove some duplicate code

Signed-off-by: Yihe Li <winmikedows@hotmail.com>

launcher/BaseInstance.h

@@ -78,6 +78,10 @@ struct ShortcutData {
     ShortcutTarget target = ShortcutTarget::Other;
 };
 
+/// Console settings
+int getConsoleMaxLines(SettingsObjectPtr settings);
+bool shouldStopOnConsoleOverflow(SettingsObjectPtr settings);
+
 /*!
  * \brief Base class for instances.
  * This class implements many functions that are common between instances and
@@ -272,9 +276,6 @@ class BaseInstance : public QObject, public std::enable_shared_from_this<BaseIns
 
     Status currentStatus() const;
 
-    int getConsoleMaxLines() const;
-    bool shouldStopOnConsoleOverflow() const;
-
     QStringList getLinkedInstances() const;
     void setLinkedInstances(const QStringList& list);
     void addLinkedInstanceId(const QString& id);