Check return value of 'QFile::open(QIODeviceBase::OpenMode)' (#4274)

2025-11-06 09:47:33 +01:00
parent a34cdf0519 8d42bdaf6b
commit f835d00f77
9 changed files with 63 additions and 28 deletions
--- a/launcher/ui/dialogs/AboutDialog.cpp
+++ b/launcher/ui/dialogs/AboutDialog.cpp
@@ -59,9 +59,14 @@ QString getCreditsHtml()
 QString getLicenseHtml()
 {
    QFile dataFile(":/documents/COPYING.md");
-    dataFile.open(QIODevice::ReadOnly);
-    QString output = markdownToHTML(dataFile.readAll());
-    return output;
+    if (dataFile.open(QIODevice::ReadOnly)) {
+        QString output = markdownToHTML(dataFile.readAll());
+        dataFile.close();
+        return output;
+    } else {
+        qWarning() << "Failed to open file '" << dataFile.fileName() << "' for reading!";
+        return QString();
+    }
 }

 }  // namespace