Merge pull request #2917 from Trial97/asan_log

fix heap-use-after-free in modrinth creation task
2024-10-18 12:09:24 +02:00
parent 43eb27b695 ac13579b99
commit f60d6e4d48
1 changed files with 7 additions and 0 deletions
--- a/launcher/modplatform/modrinth/ModrinthInstanceCreationTask.cpp
+++ b/launcher/modplatform/modrinth/ModrinthInstanceCreationTask.cpp
@@ -301,6 +301,13 @@ bool ModrinthCreationTask::createInstance()

    loop.exec();

+    if (!ended_well) {
+        for (auto m : mods) {
+            delete m;
+        }
+        return ended_well;
+    }
+
    QEventLoop ensureMetaLoop;
    QDir folder = FS::PathCombine(instance.modsRoot(), ".index");
    auto ensureMetadataTask = makeShared<EnsureMetadataTask>(mods, folder, ModPlatform::ResourceProvider::MODRINTH);